CommitFest 2008-11

From PostgreSQL Wiki

(Redirected from CommitFestInProgress)
Jump to: navigation, search

Contents


This is the page for the CommitFest starting 2008 November.

Managers for this CommitFest are Josh Berkus (josh-at-agliodbs-com) and Dave Page (dpage-at-pgadmin-org).

Current commitfest

This is the commitfest currently in progress

Reviewers are currently working on patches in this queue. If you want to help, please see our reviewer's guide.

If you have a new patch to submit, please add it at CommitFestOpen.

For guidance on working with commitfest wiki pages, please see CommitFest Help.

Pending patches

Patch Status Author Reviewers

SE-PostgreSQL and related

SE-PostgreSQL patches Pending review Kaigai Kohei

Tom Lane, Simon Riggs, Bruce Momjian

KaiGai says: SEPostgreSQL is a draft of comprehensive document
KaiGai says: The latest patches to be reviewed (r1268), as of Dec. 1
Column-level Permissions Waiting on Author Stephen Frost

Markus Wanner,Alvaro Herrera

Stephen Frost says: Updated patch here
Review: Markus Wanner says: Awaiting updated patch.
Stephen Frost says: Updated patch, again, here
Stephen Frost says: Updated patch, fixes case where unprivileged user can get row count, here
alvherre says: Updated patch
Robert Haas says: Stephen Frost agreed to make some minor changes 2008-11-25

Recovery, Replication, Hot Standby

Infrastructure changes for recovery Waiting on author Simon Riggs

Tom Lane, Heikki Linnakangas

sriggs says: important patch for other work
Robert Haas says: patch v9 here, in response to Heikki's review
sriggs says: some issues overlooked, fixed as part of Hot Standby patch only at present
sriggs says: do we want this split out again as a separate patch for easier review?
Robert Haas says: looks like the consensus is that this should be split back out as a separate patch
Dave Page says: Heikki reports he is waiting on Simon for a split set of patches 2008-11-27
Hot Standby - queries during archive recovery Pending Review Simon Riggs

Pavan Deolasee, Koichi Suzuki

sriggs says: v5d now available, fixing all Mark's reported issues. Main parts are fully reviewable
sriggs says: Wiki contains dynamically updated list of outstanding items Hot_Standby
rmgr hooks and contrib/rmgr_hook Waiting on dependencies Simon Riggs

Nobody

sriggs says: deferrable, if required
tgl says: I think the plan is for this to wait till "infrastructure" patch goes in
Synchronous log-shipping replication Pending review Masao Fujii

Heikki Linnakangas, Simon Riggs

fujii says: signal handling patch v2 here
fujii says: walsender process patch v1 here
fujii says: Synch Rep patch v2 here
fujii says: Synch Rep patch v3 here
Dave Page says: Heikki reports he is yet to review latest version. Is going to look at signal handling part, and commit first if OK 2008-11-27
fujii says: Synch Rep patch v4 here
Dave Page says: Simon reports his review is ongoing 2008-11-27
sriggs says: First Thoughts on Code
fujii says: I illustrated the architecture here

Upgrade-in-place and related issues

htup and bufpage API clean up Waiting on author Zdenek Kotala

Robert Haas

Zdenek Kotala says: New version is here
Robert Haas says: author plans to resubmit but it's not his top priority 2008-11-26

SQL language features

Window Functions Pending review Hitoshi Harada

Heikki Linnakangas, David Rowley, Tom Lane

Hitoshi Harada says: updated patch is here
Hitoshi Harada says: updated patch is here
Hitoshi Harada says: updated patch is here, still some issues on ntile and nth_value
Hitoshi Harada says: updated patch is here
Dave Page says: David reports that he's waiting on an updated patch from Heikki before continuing review 2008-11-26
Dave Page says: Heikki reports he's not currently reviewing this, but has refactored the code 2008-11-27
add columns via CREATE OR REPLACE VIEW Pending review Robert Haas

Bernd Helmle

Robert Haas says: some further justification of the proposed design here
Robert Haas says: questions about how to move forward here
Robert Haas says: a similar feature request from Andrew Dunstan
Dave Page says: Bernd reports he has found some issues and expects to report to the list/Robert today 2008-11-27
Bernd Helmle says: Found a problem when using domains with constraints here
Robert Haas says: new version here 2008-12-01
Automatic view update rules Waiting on author Bernd Helmle

Unicron,Robert Haas

Bernd Helmle says: New version with RETURNING support here
Wolf Wei says: it can be built and executed successfully, automatic insert/update/delete on view based on single table can work
Review: Robert Haas says: fails regression tests, and a few other comments 2008-11-11
Robert Haas says: author plans to resubmit 2008-11-26
Enable pl/python to return records based on multiple OUT params Waiting on author Hannu Krosing

Nobody

Robert Haas says: Hannu is working on a new version
Robert Haas says: oh, i guess Hannu actually isn't working on a new version, but says the previous version is ready to go 2008-11-27
tgl says: as I read the above-linked message, Hannu is still working on it

Indexes

GIN fast insert Pending review Teodor Sigaev, Oleg Bartunov

Jeff Davis

Robert Haas says: some complaints from Heikki 2008-11-27
B-Tree emulation for GIN WIP Teodor Sigaev, Oleg Bartunov

Jeff Davis

Teodor Sigaev says: new version of btree_gin
Oleg Bartunov says: benefits of btree_gin
On-disk bitmap indexes WIP Gabriele Bartolini, Gianni Ciolli

Greg Stark (more welcome!)

Review: Teodor Sigaev says: several bugs

Performance

Improve Performance of Multi-Batch Hash Join for Skewed Data Sets Pending review Ramon Lawrence/Bryce Cutt

Joshua Tolley

Joshua Tolley says: [1] reports backend crash
tgl says: updated patch here
tgl says: some concerns here
Dave Page says: Josh reports performance testing is ongoing 2008-11-26
posix_fadvise Waiting on author Gregory Stark

Robert Haas

Review: Robert Haas says: looks pretty clean, but needs some cleanup, maybe should be 2 patches
Dave Page says: Latest patch (v20)
Robert Haas says: author still needs to rip out some more posix_fallocate stuff and maybe fine-tune the docs
Proposal of PITR performance improvement Pending review Koichi Suzuki

Simon Riggs

Robert Haas says: V2 from patch author
Hash Join-Filter Pruning using Bloom Filters WIP Jonah Harris

Unicron

Improving admin experience

Block-level CRC checks WIP Alvaro Herrera

Nobody

alvherre says: updated patch here
Auto Partitioning Patch WIP Nikhil Sontakke

Jaime Casanova

jcasanov says: some comments here
Robert Haas says: a few more thoughts here
Reducing some DDL Locks to ShareLock Waiting on author Simon Riggs

Tom Lane

tgl says: v6 patch here
sriggs says: agreed rework to implement pg_domain constraint, but the main patch still needs review
tgl says: I think we'd decided to pass on the pg_constraint restructuring, at least for now
tgl says: partially applied, what's left is here

Connection management

Client SSL key/certificate/etc file name specification Pending review Alvaro Herrera

Magnus Hagander, Alex Hunsaker

Magnus says: Picked up from having been dropped from a previous commit fest, this is the latest updated version
Magnus says: Updated patch

Contrib modules

contrib/pg_stat_statements Pending review Takahiro Itagaki

Alex Hunsaker

Itagaki says: updated version here (2008-12-02).
pg_standby support for compressed segments Pending review Charles Duffy

Simon Riggs

Simon Riggs says: Deferring review for a few weeks until we get a better picture of streaming replication requirements for 8.4
Simple postgresql.conf wizard Pending review Greg Smith

Josh Berkus

Greg Smith says: Updated V2
Greg Smith says: Updated V3

Clients

pg_dump roles support Pending review Benedek Laszlo

Ibrar Ahmed

alvherre says: there's an updated patch, and some extra comments
parallel restore WIP Andrew Dunstan

Kenneth Marshall

Miscellaneous

Solve a problem of LC_TIME of windows Pending review Hiroshi Saito

Nobody

mha says: Even newer version here
itagaki says: a new version of the patch here
Support PLUGINS lines in Makefiles, similar to MODULES No response from author Asif Naeem

Robert Haas

Dave Page says: This doesn't work with the edb-debugger plugin, which is the only such plugin around AFAIK. It needs to ignore comments on the PLUGINS line, and handle multiple targets (plugin_debugger, pldbgapi, targetinfo etc). Not sure if we want that complexity though.
Heikki says: Unix-makefile version: here
Robert Haas says: waiting for response to email sent to author 2008-11-28
autovacuum and reloption Pending review Euler Taveira de Oliveira

Alvaro Herrera

Robert Haas says: author is working on a new version
tgl says: new version is here
Dave Page says: Alvaro reports he is working on an updated patch 2008-11-28
SQL/MED compatible connection manager WIP Martin Pihlak

Peter Eisentraut

Martin Pihlak says: Updated patch here
pre-MED Waiting on author David Fetter

Alex Hunsaker

David Fetter says: Updated patch here
Review: alexhun says: few questions and tgl had some constructive comments

Committed patches

Patch Status Author Reviewers
Common Table Expressions Committed 2008-10-04 Yoshiyuki Asaba

Jeff Davis

David Fetter says: README is here.
David Fetter says: Git repository is here.
David Fetter says: CTEReadme
David Fetter says: Fair Use from the draft SQL:2008 standard (WIP)
Review: tgl says: needs a good bit of work yet
Add default_val to pg_settings Committed 2008-10-06 Greg Smith

Simon Riggs,Magnus Hagander

Noisy _dosmaperror Committed 2008-10-16 Takahiro Itagaki

Tom Lane

Memory leak on hashed agg rescan Committed 2008-10-16 Neil Conway

Tom Lane

Review: Tom Lane says: move some logic to separate function
Atomic subtransaction commit Committed 2008-10-20 Simon Riggs

Alvaro Herrera

add placeholder variables to planner Committed 2008-10-22 Tom Lane

Nobody

pg_hba options parsing Committed 2008-10-23 Magnus Hagander

Bruce Momjian

Robert Haas says: updated patch
libpq ssl -> clear fallback looses error messages Committed 2008-10-27 Magnus Hagander

Nobody

better hba parsing error messages Committed 2008-10-27 Magnus Hagander

Nobody

remove crypt authentication Committed 2008-10-28 Magnus Hagander

Nobody

Unicode escapes in literals Committed 2008-10-29 Peter Eisentraut

Nobody

User defined I/O conversion casts Committed 2008-10-31 Heikki Linnakangas

Nobody

Updating FSM on recovery Committed 2008-10-31 Heikki Linnakangas

Nobody

use new heap_(form/deform/modify)_tuple API Committed 2008-11-01 Kris Jurka

Zdenek Kotala

Zdenek Kotala says: It seems OK. Needs apply also pfree patch.
don't use MAKE_PTR/OFFSET for shmem pointers Committed 2008-11-02 Kris Jurka

Tom Lane

reducing statistics write overhead Committed 2008-11-02 Martin Pihlak

Tom Lane

Martin Pihlak says: Latest patch here
pg_typeof() Committed 2008-11-03 Brendan Jurd

Kurt Harriman

Kurt Harriman says: Updated patch is ready to commit if there is no objection
Fixes for psql describeOneTableDetails Committed 2008-11-03 Kris Jurka

Tom Lane

PageGetTempPage cleanup Committed 2008-11-03 Zdenek Kotala

Tom Lane

Zdenek Kotala says: Original discussion here
Allow the UUID type to accept non-standard formats Committed 2008-11-03 Robert Haas

Peter Eisentraut

array_ndims Committed 2008-11-04 Robert Haas

Peter Eisentraut

bulk inserts - keep most recent page pinned Committed 2008-11-06 Robert Haas

Tom Lane

Robert Haas says: based on work by Simon Riggs: original idea,original patch, Tom Lane's comments
Robert Haas says: Tom's comments on my design proposal are here
Robert Haas says: patch v2, adjusting for Heikki's changes to the ReadBuffer interface
ALTER DATABASE SET TABLESPACE Statement Committed 2008-11-07 Guillaume Lelarge

Bernd Helmle

Bernd Helmle says: Syntax discussion and updated version here
Guillaume Lelarge says: Updated version with SET syntax here
Bernd Helmle says: Updated version from Guillaume here
Guillaume Lelarge says: Updated version here
Tests citext casts Committed 2008-11-07 David Wheeler

Kenneth Marshall

SQL Standard Interval output and IntervalStyle GUC Committed 2008-11-08 Ron Mayer

Brendan Jurd

Ron Mayer says: Early updates here, here, and here. Mostly related to GUC changes.
Review: BJ says: Bug in output, stylistic suggestions
the mailing list says: Feedback from Tom L and Kevin G about mixed-sign intervals
Ron Mayer says: Updated patch here to fix -12:01:-30 bug and style suggestions from the review and to attempt to address feedback about mixed-sign intervals with doc updates.
Review: BJ says: One last typo in docs but otherwise all good; review complete
Review: Tom L says: Tom pointed out issues with pg_dump and restore into databases with a different interval style
Ron Mayer says: Speculating if an analogy with standard_conforming_strings applies to how we can handle dump/restore.
ISO 8601 interval literal input and output Committed 2008-11-10 Ron Mayer

Brendan Jurd

Ron Mayer says: The initial (2003) version of this patch along with a thread which explains the feature a bit more can be found here.
Robert Haas says: latest version
Review: BJ says: Code style and documentation suggestions
Ron Mayer says: Update here here that fixes style & docs; as well as a bug where the ISO8601 spec wasn't quite followed (an optional field was treated as required by previous patches).
Review: BJ says: Query behaviour of 'P0001', final doc cleanup suggestions
Ron Mayer says: Update here here that fixes 'P0001' and updated docs.
Interval rounding consistency Committed 2008-11-11 Ron Mayer

Brendan Jurd

Ron Mayer says: Patch 3 here refactors the interval code to remove much of the copy&paste in DecodeInterval and EncodeInterval with the side effect of making interval rounding more consistent between styles. This patch applies on top of the IntervalStyle patch and the ISO 8601 Interval patch.
Review: BJ says: Code style cleanups, a couple queries
array_length Committed 2008-11-12 Jim C. Nasby

Peter Eisentraut

Robert Haas says: I have reimplemented this in C
SSL cleanups/hostname verification Committed 2008-11-13 Magnus Hagander

Alex Hunsaker

Magnus says: Updated patch
Review: alexhun says: looks good
array_agg/array_accum Committed 2008-11-13 Robert Haas

Peter Eisentraut

Robert Haas says: another version and another one from Jeff Davis
contrib/auto_explain Committed 2008-11-18 Takahiro Itagaki

Jeff Davis

Jeff says: minor documentation edits by reviewer
Itagaki says: latest patch versions
clientcert option for pg_hba Committed 2008-11-20 Magnus Hagander

Unicron, Alex Hunsaker

Review: alexhun says: Quick review, new patch looks good
client certificate authentication Committed 2008-11-20 Magnus Hagander

Alex Hunsaker

Magnus says: Dependant on the "clientcert option for pg_hba" patch
Review: alexhun says: Looks good
TABLE command Committed 2008-11-20 Peter Eisentraut

Unicron, Robert Haas

Unicron says: Patch works per specification
Review: Robert Haas says: wrong non-terminal, needs doc and psql updates
adding VERBOSE option to CLUSTER Committed 2008-11-24 Jim Cox

Peter Eisentraut

regexp support in usermaps Committed 2008-11-28 Magnus Hagander

Gianni Ciolli

Magnus says: Updated patch
Gianni Ciolli says: The second version looks like ready to me.
pg_stop_backup wait bug fix Committed 2008-12-03 Simon Riggs

Ibrar Ahmed, Heikki Linnakangas

Robert Haas says: sriggs extracted this from recovery infrastructure patch per Heikki's suggestion
Robert Haas says: heikki has an updated version
Visibility map, partial vacuums Committed 2008-12-03 Heikki Linnakangas

Tom Lane

tgl says: updated patch here
tgl says: Nearly committable, some nits here
libpq callback unregistration Committed 2008-12-03 Bruce Momjian

Magnus Hagander

Magnus says: Needs more work, comments here
alvherre says: Bruce posted a new version, but it still needs some work
Magnus says: Updated patch
default values for function's parameters Committed 2008-12-04 Pavel Stehule

Peter Eisentraut

Pavel Stehule says: fix known bugs, currently only doc should be finished
Peter Eisentraut says: data type for catalog entries needs change
Robert Haas says: Pavel just posted a new version 2008-11-26

Returned with Feedback

Patch Status Author Reviewers
new correlation metric Pending rework Jeff Davis

Brendan Jurd

In-place online upgrade Removed from queue per author Zdenek Kotala

Robert Haas

Zdenek Kotala says: This patch requires "htup and bufpage API clean up" and "HeapTuple version extension" patches. Git repository is here
Review: Robert Haas says: preliminary comments, still need a clean diff
Extending pg_class info + more flexible TOAST chunk size Removed from queue per author Zdenek Kotala

Robert Haas

tgl says: seems it'd be better to make TOAST chunks work like this
tgl says: Alvaro has a draft patch for that
Optimizing COPY with memchr() WIP Heikki Linnakangas

Robert Haas

tgl says: does this really need any more review at this point?
Robert Haas says: asked author for a status update
Robert Haas says: will not be ready for 8.4
grouping sets WIP Pavel Stehule

Ibrar Ahmed

Pavel Stehule says: doc and notes Grouping Sets
Pavel Stehule says: actualised patch http://www.pgsql.cz/patches/gsets.diff.gz
tgl says: Pavel says this is not intended for 8.4
Ibrar says: Review complete
Distinct types WIP Peter Eisentraut

Nobody

Bernd Helmle says: Patch needs further work regarding indexing
tgl says: I don't think the type-system behavior has been thought through properly

Rejected Patches

Patch Status Author Reviewers
FAQ_Solaris 1.28 to spanish Rejected Emanuel CALVO FRANCO

Peter Eisentraut

Peter Eisentraut says: We are not ready to maintain translations of this type of material.
HeapTuple version extension + code cleanup Rejected Zdenek Kotala

Robert Haas

Review: Robert Haas says: proposed API seems too costly and fragile
Robert Haas says: I think we have consensus that this is not the right approach
Prepared transactions and temp tables Rejected Emmanuel Cecchet

Heikki Linnakangas

tgl says: new patch version here
Robert Haas says: new patch version from Emmanuel, who says he needs feedback from Heikki before proceeding further 2008-12-01
Heikki says: I think we need to take a completely different approach.

Round Robin Reviewers

Name Status Reviewing Completed
Brendan Jurd Available 0 4
Jaime Casanova Available 1 1
Stephen Frost Available 11/15 0 0
Jeff Davis Available 2 1
Greg Stark Unknown 1 0
Abhijit Menon-Sen Unknown 0 0
Alex Hunsaker Available 1 1
Markus Wanner Cherry-picking 1 0
Ibrar Ahmed Available 1 0
D'Arcy Cain Unknown 0 0
Kenneth Marshall Available 1 1
Robert Haas Available 1 6
Matthew Wetmore Out-of-contact 0 0
Gianni Colli Available 1 0
"Unicron" Available 1 3
Pavan Deolasee Available 1 0
Retrieved from "http://www.postgresqldocs.org/wiki/CommitFest_2008-11"
Personal tools